Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change rvm to rbenv #6816

Merged
merged 4 commits into from
Mar 12, 2024
Merged

fix: change rvm to rbenv #6816

merged 4 commits into from
Mar 12, 2024

Conversation

sidhujus
Copy link
Contributor

Which issue(s) does this change fix?

changing ruby version manager

Why is this change necessary?

appveyor no longer uses rvm in their image

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sidhujus sidhujus requested a review from a team as a code owner March 12, 2024 19:24
@sidhujus sidhujus requested review from mndeveci and lucashuy March 12, 2024 19:24
appveyor-ubuntu.yml Outdated Show resolved Hide resolved
appveyor-ubuntu.yml Outdated Show resolved Hide resolved
@sidhujus sidhujus enabled auto-merge March 12, 2024 20:26
@sidhujus sidhujus added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 698585f Mar 12, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants